Skip to content

Conversation

@tstellar
Copy link
Collaborator

@tstellar tstellar commented Dec 3, 2025

@llvmbot
Copy link
Member

llvmbot commented Dec 3, 2025

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

https://discourse.llvm.org/t/rfc-display-true-result-for-aarch64-pre-commit-ci/88928


Full diff: https://github.com/llvm/llvm-project/pull/170535.diff

1 Files Affected:

  • (modified) .github/workflows/premerge.yaml (-1)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 10f7f6a827b30..110cd9a70e950 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -63,7 +63,6 @@ jobs:
           fetch-depth: 2
       - name: Build and Test
         timeout-minutes: 120
-        continue-on-error: ${{ runner.arch == 'ARM64' }}
         env:
           GITHUB_TOKEN: ${{ github.token }}
           GITHUB_PR_NUMBER: ${{ github.event.pull_request.number }}

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given there seems to be unanimous support on the RFC.

@tstellar tstellar merged commit 0c31da1 into llvm:main Dec 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants