[Flang][OpenMP] Only allow implicit mappers for Allocatables.

[TIFitis]

Generate implicit declare mappers only for Allocatables.

Fixes #169382 introduced by #140562.

[llvmbot]

@llvm/pr-subscribers-flang-fir-hlfir

Author: Akash Banerjee (TIFitis)

Changes

Generate implicit declare mappers only for Allocatables.

Fixes #169382 introduced by #140562.

---

Full diff: https://github.com/llvm/llvm-project/pull/170701.diff

1 Files Affected:

• (modified) flang/lib/Lower/OpenMP/Utils.cpp (+1-1)

diff --git a/flang/lib/Lower/OpenMP/Utils.cpp b/flang/lib/Lower/OpenMP/Utils.cpp
index ccac64335c29a..a818d635668de 100644
--- a/flang/lib/Lower/OpenMP/Utils.cpp
+++ b/flang/lib/Lower/OpenMP/Utils.cpp
@@ -189,7 +189,7 @@ bool requiresImplicitDefaultDeclareMapper(
 
     semantics::DirectComponentIterator directComponents{spec};
     for (const semantics::Symbol &component : directComponents) {
-      if (semantics::IsAllocatableOrPointer(component))
+      if (component.attrs().test(semantics::Attr::ALLOCATABLE))
         return true;
 
       if (const semantics::DeclTypeSpec *declType = component.GetType())

[Copilot]

Pull request overview

This PR restricts implicit declare mapper generation in OpenMP to only allocatable components, excluding pointer components. This fixes issue #169382 that was introduced by PR #140562.

• Modified the condition in requiresImplicitDefaultDeclareMapper to check only for allocatable attributes instead of both allocatable and pointer attributes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[agozillon]

LGTM, thank you for the fix!