Skip to content

[lldb][NFC] Replace const std::vector& with ArrayRef in APIs #170834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felipepiovezan wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −43
Open

[lldb][NFC] Replace const std::vector& with ArrayRef in APIs #170834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions lldb/include/lldb/Core/Module.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,29 +298,12 @@ class Module : public std::enable_shared_from_this<Module>,
/// matches.
void FindCompileUnits(const FileSpec &path, SymbolContextList &sc_list);

/// Find functions by lookup info.
///
/// If the function is an inlined function, it will have a block,
/// representing the inlined function, and the function will be the
/// containing function. If it is not inlined, then the block will be NULL.
///
/// \param[in] lookup_info
/// The lookup info of the function we are looking for.
///
/// \param[out] sc_list
/// A symbol context list that gets filled in with all of the
/// matches.
void FindFunctions(const LookupInfo &lookup_info,
const CompilerDeclContext &parent_decl_ctx,
const ModuleFunctionSearchOptions &options,
SymbolContextList &sc_list);

/// Find functions by a vector of lookup infos.
///
/// If the function is an inlined function, it will have a block,
/// representing the inlined function, and the function will be the
/// containing function. If it is not inlined, then the block will be NULL.
void FindFunctions(const std::vector<LookupInfo> &lookup_infos,
void FindFunctions(llvm::ArrayRef<LookupInfo> lookup_infos,
const CompilerDeclContext &parent_decl_ctx,
const ModuleFunctionSearchOptions &options,
SymbolContextList &sc_list);
Expand Down
7 changes: 3 additions & 4 deletions lldb/include/lldb/Symbol/SymbolFile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,9 @@ class SymbolFile : public PluginInterface {
virtual void FindFunctions(const Module::LookupInfo &lookup_info,
const CompilerDeclContext &parent_decl_ctx,
bool include_inlines, SymbolContextList &sc_list);
virtual void
FindFunctions(const std::vector<Module::LookupInfo> &lookup_infos,
const CompilerDeclContext &parent_decl_ctx,
bool include_inlines, SymbolContextList &sc_list);
virtual void FindFunctions(llvm::ArrayRef<Module::LookupInfo> lookup_infos,
const CompilerDeclContext &parent_decl_ctx,
bool include_inlines, SymbolContextList &sc_list);
virtual void FindFunctions(const RegularExpression &regex,
bool include_inlines, SymbolContextList &sc_list);

Expand Down
25 changes: 8 additions & 17 deletions lldb/source/Core/Module.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,33 +820,24 @@ void Module::LookupInfo::Prune(SymbolContextList &sc_list,
}
}

void Module::FindFunctions(const Module::LookupInfo &lookup_info,
void Module::FindFunctions(llvm::ArrayRef<Module::LookupInfo> lookup_infos,
const CompilerDeclContext &parent_decl_ctx,
const ModuleFunctionSearchOptions &options,
SymbolContextList &sc_list) {
// Find all the functions (not symbols, but debug information functions...
if (SymbolFile *symbols = GetSymbolFile()) {
for (auto &lookup_info : lookup_infos) {
SymbolFile *symbols = GetSymbolFile();
if (!symbols)
continue;

symbols->FindFunctions(lookup_info, parent_decl_ctx,
options.include_inlines, sc_list);
// Now check our symbol table for symbols that are code symbols if
// requested
if (options.include_symbols) {
if (Symtab *symtab = symbols->GetSymtab()) {
if (options.include_symbols)
if (Symtab *symtab = symbols->GetSymtab())
symtab->FindFunctionSymbols(lookup_info.GetLookupName(),
lookup_info.GetNameTypeMask(), sc_list);
}
}
}
}

void Module::FindFunctions(const std::vector<Module::LookupInfo> &lookup_infos,
const CompilerDeclContext &parent_decl_ctx,
const ModuleFunctionSearchOptions &options,
SymbolContextList &sc_list) {
for (auto &lookup_info : lookup_infos)
FindFunctions(lookup_info, parent_decl_ctx, options, sc_list);
}

void Module::FindFunctions(ConstString name,
const CompilerDeclContext &parent_decl_ctx,
FunctionNameType name_type_mask,
Expand Down
8 changes: 4 additions & 4 deletions lldb/source/Symbol/SymbolFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ void SymbolFile::FindFunctions(const Module::LookupInfo &lookup_info,
bool include_inlines,
SymbolContextList &sc_list) {}

void SymbolFile::FindFunctions(
const std::vector<Module::LookupInfo> &lookup_infos,
const CompilerDeclContext &parent_decl_ctx, bool include_inlines,
SymbolContextList &sc_list) {
void SymbolFile::FindFunctions(llvm::ArrayRef<Module::LookupInfo> lookup_infos,
const CompilerDeclContext &parent_decl_ctx,
bool include_inlines,
SymbolContextList &sc_list) {
for (const auto &lookup_info : lookup_infos)
FindFunctions(lookup_info, parent_decl_ctx, include_inlines, sc_list);
}
Expand Down
Loading