Fix char traits eq hide from abi

[smundhra-git]

[libcxx] Replace _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI in char_traits::eq

This removes the TODO comment and makes the eq function consistent
with the lt function below it, which already uses _LIBCPP_HIDE_FROM_ABI.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Shlok Mundhra (smundhra-git)

Changes

[libcxx] Replace _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI in char_traits::eq

This removes the TODO comment and makes the eq function consistent
with the lt function below it, which already uses _LIBCPP_HIDE_FROM_ABI.

---

Full diff: https://github.com/llvm/llvm-project/pull/171020.diff

1 Files Affected:

• (modified) libcxx/include/__string/char_traits.h (+1-2)

diff --git a/libcxx/include/__string/char_traits.h b/libcxx/include/__string/char_traits.h
index 8292750919427..70b0f92639873 100644
--- a/libcxx/include/__string/char_traits.h
+++ b/libcxx/include/__string/char_traits.h
@@ -93,8 +93,7 @@ struct char_traits<char> {
     __c1 = __c2;
   }
 
-  // TODO: Make this _LIBCPP_HIDE_FROM_ABI
-  static inline _LIBCPP_HIDDEN _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type __c2) _NOEXCEPT {
+  static inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type __c2) _NOEXCEPT {
     return __c1 == __c2;
   }
   static inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool lt(char_type __c1, char_type __c2) _NOEXCEPT {