[dsymutil] Remove spurious exit when falling back to fat64 header #171189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In llvm#118898 I changed dsymutil to emit a warning instead of an error when exceeding the 4GB limit for a slice and automatically fall back to using the fat64 header. However, while doing so, I forgot to remove the return which defeats that purpose. rdar://140998416
Member
|
@llvm/pr-subscribers-debuginfo Author: Jonas Devlieghere (JDevlieghere) ChangesIn #118898 I changed dsymutil to emit a warning instead of an error when exceeding the 4GB limit for a slice and automatically fall back to using the fat64 header. However, while doing so, I forgot to remove the return which defeats that purpose. rdar://140998416 Full diff: https://github.com/llvm/llvm-project/pull/171189.diff 1 Files Affected:
diff --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp
index 688f6aaf3d0c9..a71c57c60593c 100644
--- a/llvm/tools/dsymutil/dsymutil.cpp
+++ b/llvm/tools/dsymutil/dsymutil.cpp
@@ -873,7 +873,6 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
"-fat64 flag to force a 64-bit header and silence this "
"warning.",
FileOffset);
- return EXIT_FAILURE;
}
FileOffset += stat->getSize();
}
|
adrian-prantl
approved these changes
Dec 8, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/18684 Here is the relevant piece of the build log for the reference |
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Dec 8, 2025
…vm#171189) In llvm#118898 I changed dsymutil to emit a warning instead of an error when exceeding the 4GB limit for a slice and automatically fall back to using the fat64 header. However, while doing so, I forgot to remove the return which defeats the whole purpose. rdar://140998416 (cherry picked from commit 83fd2c9)
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…vm#171189) In llvm#118898 I changed dsymutil to emit a warning instead of an error when exceeding the 4GB limit for a slice and automatically fall back to using the fat64 header. However, while doing so, I forgot to remove the return which defeats the whole purpose. rdar://140998416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #118898 I changed dsymutil to emit a warning instead of an error when exceeding the 4GB limit for a slice and automatically fall back to using the fat64 header. However, while doing so, I forgot to remove the return which defeats that purpose.
rdar://140998416