Skip to content

Fix a typo in "breakpoint add file" and add a test #171206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimingham merged 1 commit into from
Dec 8, 2025
Merged

Fix a typo in "breakpoint add file" and add a test #171206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Commands/CommandObjectBreakpoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ class CommandObjectBreakpointAddFile : public CommandObjectParsed {
m_cur_value.SetLine(line_num);
}
break;
case 'c':
case 'u':
uint32_t column_num;
if (option_arg.getAsInteger(0, column_num))
error = Status::FromError(
Expand Down
19 changes: 19 additions & 0 deletions ...functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,25 @@ def testBreakpointByLineAndColumn(self):
in_then |= b_loc.GetColumn() == 50
self.assertTrue(in_then)

def testBreakpointByLineAndColumnUsingCLI(self):
self.build()
src_file = lldb.SBFileSpec("main.cpp")
line = (
line_number("main.cpp", "At the beginning of a function name (col:50)") + 1
) # Next line after comment
target, process, _, _ = lldbutil.run_to_source_breakpoint(self, "This is a random comment", src_file)
bkpt_no = lldbutil.run_break_set_by_file_and_line(self, "main.cpp", line, "--column 50")
breakpoint = target.FindBreakpointByID(bkpt_no)
threads = lldbutil.continue_to_breakpoint(process, breakpoint)
self.assertEqual(len(threads), 1, "Stopped at our breakpoint")
self.expect("fr v did_call", substrs=["1"])
in_then = False
for i in range(breakpoint.GetNumLocations()):
b_loc = breakpoint.GetLocationAtIndex(i).GetAddress().GetLineEntry()
self.assertEqual(b_loc.GetLine(), line)
in_then |= b_loc.GetColumn() == 50
self.assertTrue(in_then)

## Skip gcc version less 7.1 since it doesn't support -gcolumn-info
@skipIf(compiler="gcc", compiler_version=["<", "7.1"])
def testBreakpointByLine(self):
Expand Down
Loading