Skip to content

[libc++] Implement views::join_with #65536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Jun 21, 2025
Merged

[libc++] Implement views::join_with #65536

merged 56 commits into from
Jun 21, 2025

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Sep 6, 2023 •
edited
Loading

@github-actions github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 6, 2023
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 5 times, most recently from 3259db4 to 0481670 Compare September 8, 2023 00:07
Zingam
Zingam reviewed Sep 8, 2023
View reviewed changes
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from 0481670 to f113229 Compare September 8, 2023 15:11
@ldionne ldionne assigned var-const and huixie90 and unassigned var-const Sep 13, 2023
@ldionne ldionne requested a review from huixie90 September 15, 2023 20:55
@ldionne
Copy link
Member

ldionne commented Sep 15, 2023

@JMazurkiewicz Please ping us when this is ready to review and make it a non-draft.

@philnik777 philnik777 added the ranges Issues related to `<ranges>` label Oct 6, 2023
@JMazurkiewicz JMazurkiewicz mentioned this pull request Oct 24, 2023
Merged
ldionne pushed a commit that referenced this pull request Oct 24, 2023
@JMazurkiewicz
[libc++] Update status of P2770R0, P2441R2 and P2711R1 (#70045)
e1e0598 
This patch adds a mention that the following papers are in progress:

* P2770R0: #66033
* P2441R2 and P2711R1: #65536
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from f113229 to 1835f68 Compare February 2, 2024 23:57
@github-actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review February 4, 2024 14:58
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 4, 2024 14:58
@H-G-Hristov
Copy link
Contributor

H-G-Hristov commented May 10, 2024 •
edited
Loading

I guess with constexpr variant this cool feature can be finalized now :)

@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from a84985a to fcdf64a Compare May 14, 2024 14:38
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from 54a741c to a9a1031 Compare May 22, 2024 23:17
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from a9a1031 to 9406093 Compare June 5, 2024 09:49
@JMazurkiewicz
Copy link
Contributor Author

JMazurkiewicz commented Apr 14, 2025

Ping @huixie90

huixie90
huixie90 approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@huixie90 huixie90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits. Thanks very much for the patch!

@ldionne ldionne added pending-ci Merging the PR is only pending completion of CI and removed pending-ci Merging the PR is only pending completion of CI labels May 12, 2025
@ldionne
Copy link
Member

ldionne commented May 12, 2025

Sorry for the churn about the pending-ci tag -- I missed that there were still a few comments to resolve before merging.

@JMazurkiewicz
Copy link
Contributor Author

JMazurkiewicz commented May 20, 2025

Thank you @huixie90 for your review. I've pushed commits addressing your latest comments (95ea7bc, 8ab29fb, 7198928), and changing three more things:

  • 6cb18ac - This commit fixes problem with friendship (similar to this one) in the test suite.
  • 37525db - This commit fixes truncation warnings when testing MSVC standard library (so it's easier for them to update their llvm submodule).
  • de46d63 - LWG-4074 removed compatible-joinable-ranges, this commit updates synopsis.

@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from e08bf0c to fa9e257 Compare June 11, 2025 10:51
frederick-vs-ja
frederick-vs-ja approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI failures are probably unrelated.

@huixie90
Copy link
Member

huixie90 commented Jun 21, 2025

Merging this as comments are addressed. CI is green except for msan, which is an existing issue on main and unrelated to this patch

@huixie90 huixie90 merged commit 1bb2328 into llvm:main Jun 21, 2025
155 of 181 checks passed
@JMazurkiewicz JMazurkiewicz deleted the libcxx/ranges/join_with branch June 21, 2025 14:04
@frederick-vs-ja frederick-vs-ja mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zingam Zingam Zingam left review comments

@philnik777 philnik777 philnik777 left review comments

@huixie90 huixie90 huixie90 approved these changes

@frederick-vs-ja frederick-vs-ja frederick-vs-ja approved these changes

+1 more reviewer

@Mick235711 Mick235711 Mick235711 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@huixie90 huixie90

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. ranges Issues related to `<ranges>`

Projects

None yet

Milestone

No milestone

9 participants

@JMazurkiewicz @ldionne @H-G-Hristov @Zingam @huixie90 @Mick235711 @frederick-vs-ja @philnik777 @var-const