[ARM] Fix printing of 'pop' alias. #67181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition to print the 'pop' alias could never be fulfilled, because the immediate was encoded for Address Modes 2.
Rot127
changed the title
47 tasks
XVilka
suggested changes
Sep 25, 2023
XVilka
left a comment
XVilka
left a comment
There was a problem hiding this comment.
I suppose test also should be updated:
Failed Tests (1):
LLVM :: MC/Disassembler/ARM/basic-arm-instructions.txt
Contributor
|
Adding a test that exercises this would be good. |
Author
|
Yes, sorry for being sloppy. Have made it in between some other things. Will add a test/ fix the old one soon. |
Author
|
I will eventually come back to this. But currently I won't find time to finish this. We accumulated a few other LLVM fixes in Capstone anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition to print the 'pop' alias could never be fulfilled, because the immediate was encoded for Address Modes 2.