Skip to content

[LLD][RISCV] Report error for unsatisfiable RISCV_ALIGN #74121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024
Merged

[LLD][RISCV] Report error for unsatisfiable RISCV_ALIGN #74121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0524354
[LLD][RISCV] Report error for unsatisfiable RISCV_ALIGN
preames Dec 1, 2023
60dc91a
Address review comments
preames Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lld/ELF/Arch/RISCV.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,8 +686,14 @@ static bool relax(InputSection &sec) {
const uint64_t align = PowerOf2Ceil(r.addend + 2);
// All bytes beyond the alignment boundary should be removed.
remove = nextLoc - ((loc + align - 1) & -align);
assert(static_cast<int32_t>(remove) >= 0 &&
"R_RISCV_ALIGN needs expanding the content");
// If we can't satisfy this alignment, we've found a bad input.
if (LLVM_UNLIKELY(static_cast<int32_t>(remove) < 0)) {
errorOrWarn(getErrorLocation((const uint8_t*)loc) +
"insufficient padding bytes for " + lld::toString(r.type) +
": " + Twine(r.addend) + " bytes available "
"for requested alignment of " + Twine(align) + " bytes");
remove = 0;
}
break;
}
case R_RISCV_CALL:
Expand Down