Skip to content

[OpenMP][Archer][TSan] Use TSan fibers to implement task-centric analysis for OpenMP tasks #74646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[OpenMP][Archer][TSan] Use TSan fibers to implement task-centric analysis for OpenMP tasks #74646

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc6034e
Add tasking support in archer via fibers
felilxtomski Nov 30, 2023
61c6458
Fix format
felilxtomski Dec 7, 2023
1cd9f1c
Remove redundant check as suggested by @vitalybuka
jprotze Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler-rt/lib/tsan/rtl/tsan_rtl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,7 @@ void FuncExit(ThreadState *thr) {
#if !SANITIZER_GO
DCHECK_LT(thr->shadow_stack_pos, thr->shadow_stack_end);
#endif
CHECK_GT(thr->shadow_stack_pos, thr->shadow_stack);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This place is to hot for CHECK, and we have DCHECK already

thr->shadow_stack_pos--;
}

Expand Down
6 changes: 6 additions & 0 deletions compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,12 +339,16 @@ void FiberSwitchImpl(ThreadState *from, ThreadState *to) {

ThreadState *FiberCreate(ThreadState *thr, uptr pc, unsigned flags) {
void *mem = Alloc(sizeof(ThreadState));
if ((flags & FiberSwitchFlagNoSync))
thr->ignore_sync++;
ThreadState *fiber = static_cast<ThreadState *>(mem);
internal_memset(fiber, 0, sizeof(*fiber));
Tid tid = ThreadCreate(thr, pc, 0, true);
FiberSwitchImpl(thr, fiber);
ThreadStart(fiber, tid, 0, ThreadType::Fiber);
FiberSwitchImpl(fiber, thr);
if ((flags & FiberSwitchFlagNoSync))
thr->ignore_sync--;
return fiber;
}

Expand All @@ -357,6 +361,8 @@ void FiberDestroy(ThreadState *thr, uptr pc, ThreadState *fiber) {

void FiberSwitch(ThreadState *thr, uptr pc,
ThreadState *fiber, unsigned flags) {
if (thr == fiber)
return;
if (!(flags & FiberSwitchFlagNoSync))
Release(thr, pc, (uptr)fiber);
FiberSwitchImpl(thr, fiber);
Expand Down
4 changes: 4 additions & 0 deletions openmp/runtime/src/ompt-specific.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,9 +476,13 @@ int __ompt_get_task_memory_internal(void **addr, size_t *size, int blocknum) {
if (taskdata->td_flags.tasktype != TASK_EXPLICIT)
return 0; // support only explicit task

if (taskdata->td_size_alloc < 0)
return 0;

*addr = taskdata;
*size = taskdata->td_size_alloc;
return 0;

}

//----------------------------------------------------------
Expand Down
Loading