Skip to content

[Clang][CodeGen] Fix crash when using bool vector in compound assignment #75435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cygao90 wants to merge 1 commit into from
Closed

[Clang][CodeGen] Fix crash when using bool vector in compound assignment #75435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions clang/lib/CodeGen/CGExpr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2085,10 +2085,15 @@ RValue CodeGenFunction::EmitLoadOfLValue(LValue LV, SourceLocation Loc) {
}

if (LV.isVectorElt()) {
llvm::LoadInst *Load = Builder.CreateLoad(LV.getVectorAddress(),
LV.isVolatileQualified());
return RValue::get(Builder.CreateExtractElement(Load, LV.getVectorIdx(),
"vecext"));
llvm::Value *Load = nullptr;
if (LV.getType()->isExtVectorBoolType())
Load = EmitLoadOfScalar(LV.getVectorAddress(), LV.isVolatileQualified(),
LV.getType(), Loc);
else
Load =
Builder.CreateLoad(LV.getVectorAddress(), LV.isVolatileQualified());
return RValue::get(
Builder.CreateExtractElement(Load, LV.getVectorIdx(), "vecext"));
}

// If this is a reference to a subset of the elements of a vector, either
Expand Down
9 changes: 9 additions & 0 deletions clang/test/CodeGen/gh72468.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// RUN: %clang_cc1 -S -emit-llvm -o - %s

typedef __attribute__((__ext_vector_type__(4))) _Bool BoolVector;

BoolVector vec;

void f(int i, int j) {
vec[i] |= vec[j];
}
8 changes: 4 additions & 4 deletions clang/test/SemaCXX/vector-bool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ void Operations() {
// (void)(eight_bools > other_eight_bools);
// (void)(eight_bools >= other_eight_bools);

// // Legal assignments
// (void)(eight_bools |= other_eight_bools);
// (void)(eight_bools &= other_eight_bools);
// (void)(eight_bools ^= other_eight_bools);
// Legal assignments
(void)(eight_bools |= other_eight_bools);
(void)(eight_bools &= other_eight_bools);
(void)(eight_bools ^= other_eight_bools);

// Illegal operators
(void)(eight_bools || other_eight_bools); // expected-error@47 {{invalid operands to binary expression ('EightBools' (vector of 8 'bool' values) and 'EightBools')}}
Expand Down