Skip to content

Conversation

@kumar-ish
Copy link

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@github-actions
Copy link

github-actions bot commented Dec 28, 2023

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 7a48039eb79fc887f473e80618b6bc98effea077 c03024c4eb1d52014fbba695b4746068c030283b -- libcxx/include/__ranges/chunk_view.h
View the diff from clang-format here.
diff --git a/libcxx/include/__ranges/chunk_view.h b/libcxx/include/__ranges/chunk_view.h
index cf3cd85e03..eda404e45f 100644
--- a/libcxx/include/__ranges/chunk_view.h
+++ b/libcxx/include/__ranges/chunk_view.h
@@ -5,4 +5,4 @@
 #ifndef LLVM_DEV_CHUNK_VIEW_H
 #define LLVM_DEV_CHUNK_VIEW_H
 
-#endif //LLVM_DEV_CHUNK_VIEW_H
+#endif // LLVM_DEV_CHUNK_VIEW_H

@kumar-ish kumar-ish force-pushed the madhav/P2442R1-views-chunk branch from ce8e3bb to c03024c Compare December 28, 2023 11:24
@@ -0,0 +1,8 @@
//
Copy link
Contributor

@Zingam Zingam Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably remove this file if the goal is to mark that you are assigning this to yourself and also rename the title accordingly. Then we can merge it.

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Oct 25, 2024

I noticed that another author is also implementing chunk_view in #85741. Are you still working on this?

@kumar-ish
Copy link
Author

No, sorry -- I had some personal things that came up. Thanks for following up.

@kumar-ish kumar-ish closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants