Skip to content

[Github] Add initial version of precommit checks #80951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
boomanaiden154 wants to merge 2 commits into from
Closed

[Github] Add initial version of precommit checks #80951

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b3addd
[Github] Add initial version of precommit checks
boomanaiden154 Jan 20, 2024
dff96e6
Address reviewer feedback
boomanaiden154 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/workflows/precommit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: "Precommit tests"
Copy link
Collaborator

@tstellar tstellar Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we'll be able to use the same file for Windows testing? If not, I would call this "Linux Precommit Tests" and change the filename too.

Copy link
Contributor Author

@boomanaiden154 boomanaiden154 Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on a separate file per OS. Github doesn't have native runs-on support for containers on Windows, so we'll have to run the docker commands explicitly. The container image would need to be different either way, which means we would at least need separate jobs. I'm hoping to make sure common parts are pulled out into something common, but the OSes are different (at least as exposed to GHA for the way I want to use it).


permissions:
contents: read

on:
pull_request:
branches:
- main
paths:
- '.github/workflows/precommit.yaml'
- 'llvm/**'

jobs:
build-llvm:
name: "Build and test LLVM"
runs-on: ubuntu-latest
container:
image: ghcr.io/llvm/ci-ubuntu-22.04:latest
steps:
- name: Fetch LLVM sources
uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Setup ccache
uses: hendrikmuhs/ccache-action@v1
with:
max-size: 500M
variant: sccache
key: precommit-linux
- name: Configure LLVM
run: |
cmake -B llvm-build -GNinja \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_C_COMPILER_LAUNCHER=sccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DCMAKE_C_COMPILER=clang \
-DCMAKE_CXX_COMPILER=clang++ \
-DLLVM_LIT_ARGS="-v --no-progress-bar" \
./llvm
- name: Build LLVM
run: |
ninja -C llvm-build llvm-test-depends
- name: Check LLVM
run: |
ninja -C llvm-build check-llvm