Skip to content

[mlir][tosa] Add support for 0 dim in ReshapeOp #84004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[mlir][tosa] Add support for 0 dim in ReshapeOp #84004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,10 +928,16 @@ LogicalResult tosa::ReshapeOp::inferReturnTypeComponents(
// dimension.
int64_t numElements = inputShape.getNumElements();
int64_t staticMul = 1;
for (auto val : newShapeValue) {
int i = 0;
for (auto &val : newShapeValue) {
if (val == 0) {
Copy link
Contributor

@GeorgeARM GeorgeARM Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a shape value be 0?

// Swap 0 dim with corresponding input dim
val = inputShape.getDimSize(i);
}
if (!ShapedType::isDynamic(val)) {
staticMul *= val;
}
i++;
}

// Determine the length of the dynamic dimension.
Expand Down