Skip to content

[BOLT][NFCI] Use heuristic for matching split global functions #90429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2025
Merged

[BOLT][NFCI] Use heuristic for matching split global functions #90429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b7457cc
[𝘀𝗽𝗿] changes to main this commit is based on
aaupov Apr 29, 2024
72bf9f9
[𝘀𝗽𝗿] initial version
aaupov Apr 29, 2024
423bc64
[𝘀𝗽𝗿] changes introduced through rebase
aaupov Apr 29, 2024
f94b275
rebase, add test
aaupov Apr 29, 2024
6125d07
[𝘀𝗽𝗿] changes introduced through rebase
topperc Jun 20, 2025
1ce5ba7
rebase
aaupov Jun 20, 2025
7b19761
updated test
aaupov Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bolt/lib/Rewrite/RewriteInstance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,6 +1567,11 @@ void RewriteInstance::registerFragments() {

uint64_t ParentAddress{0};

// Check if containing FILE symbol is BOLT emitted synthetic symbol marking
// local fragments of global parents.
if (cantFail(FSI[-1].getName()) == getBOLTFileSymbolName())
goto registerParent;

// BOLT split fragment symbols are emitted just before the main function
// symbol.
for (ELFSymbolRef NextSymbol = Symbol; NextSymbol < StopSymbol;
Expand Down
7 changes: 7 additions & 0 deletions bolt/test/X86/register-fragments-bolt-symbols.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

# RUN: link_fdata %s %t.bolt %t.preagg PREAGG
# PREAGG: B X:0 #chain.cold.0# 1 0
# PREAGG: B X:0 #dummy# 1 0
# RUN: perf2bolt %t.bolt -p %t.preagg --pa -o %t.bat.fdata -w %t.bat.yaml -v=1 \
# RUN: | FileCheck %s --check-prefix=CHECK-REGISTER
# RUN: FileCheck --input-file %t.bat.fdata --check-prefix=CHECK-FDATA %s
Expand All @@ -44,7 +45,13 @@
# CHECK-SYMS: l F .text.cold [[#]] chain.cold.0
# CHECK-SYMS: l F .text [[#]] chain
# CHECK-SYMS: l df *ABS* [[#]] bolt-pseudo.o
# CHECK-SYMS: l F .text.cold [[#]] dummy.cold.0
# CHECK-SYMS: l F .text.cold.1 [[#]] dummy.cold.1
# CHECK-SYMS: l F .text.cold.2 [[#]] dummy.cold.2

# CHECK-REGISTER: BOLT-INFO: marking dummy.cold.0/1(*2) as a fragment of dummy
# CHECK-REGISTER: BOLT-INFO: marking dummy.cold.1/1(*2) as a fragment of dummy
# CHECK-REGISTER: BOLT-INFO: marking dummy.cold.2/1(*2) as a fragment of dummy
# CHECK-REGISTER: BOLT-INFO: marking chain.cold.0/1(*2) as a fragment of chain/2(*2)

# CHECK-FDATA: 0 [unknown] 0 1 chain/chain.s/2 10 0 1
Expand Down
Loading