Skip to content

[LAA] Use SCEVUse to add extra NUW flags to pointer bounds. (WIP) #91962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: users/fhahn/scevuse
Choose a base branch
from
Open

[LAA] Use SCEVUse to add extra NUW flags to pointer bounds. (WIP) #91962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7dd6d4b
[SCEV] Use const SCEV * explicitly in more places.
fhahn May 13, 2024
d660a7c
[SCEV] Introduce SCEVUse, use it instead of const SCEV * (NFCI) (WIP).
fhahn May 11, 2024
c362fe9
!fixup use raw pointer (const SCEV * + lower bits) for AddPointer.
fhahn May 13, 2024
e510400
!fix formatting
fhahn May 22, 2024
4b0c62b
!fixup compare getPointer() in HasSameVlue.
fhahn May 22, 2024
9a8305b
[SCEV,LAA] Add tests to make sure scoped SCEVs don't impact other SCEVs.
fhahn May 1, 2024
eed10c9
[SCEV] Don't require NUW at first add when checking A+C1 < (A+C2)<nuw>
fhahn May 13, 2024
c6f0b74
[LAA] Use SCEVUse to add extra NUW flags to pointer bounds.
fhahn May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions llvm/include/llvm/Analysis/LoopAccessAnalysis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,10 @@ struct RuntimeCheckingPtrGroup {

/// The SCEV expression which represents the upper bound of all the
/// pointers in this group.
const SCEV *High;
SCEVUse High;
/// The SCEV expression which represents the lower bound of all the
/// pointers in this group.
const SCEV *Low;
SCEVUse Low;
/// Indices of all the pointers that constitute this grouping.
SmallVector<unsigned, 2> Members;
/// Address space of the involved pointers.
Expand Down Expand Up @@ -447,10 +447,10 @@ class RuntimePointerChecking {
TrackingVH<Value> PointerValue;
/// Holds the smallest byte address accessed by the pointer throughout all
/// iterations of the loop.
const SCEV *Start;
SCEVUse Start;
/// Holds the largest byte address accessed by the pointer throughout all
/// iterations of the loop, plus 1.
const SCEV *End;
SCEVUse End;
/// Holds the information if this pointer is used for writing to memory.
bool IsWritePtr;
/// Holds the id of the set of pointers that could be dependent because of a
Expand All @@ -463,7 +463,7 @@ class RuntimePointerChecking {
/// True if the pointer expressions needs to be frozen after expansion.
bool NeedsFreeze;

PointerInfo(Value *PointerValue, const SCEV *Start, const SCEV *End,
PointerInfo(Value *PointerValue, SCEVUse Start, SCEVUse End,
bool IsWritePtr, unsigned DependencySetId, unsigned AliasSetId,
const SCEV *Expr, bool NeedsFreeze)
: PointerValue(PointerValue), Start(Start), End(End),
Expand All @@ -477,8 +477,10 @@ class RuntimePointerChecking {
/// Reset the state of the pointer runtime information.
void reset() {
Need = false;
AlwaysFalse = false;
Pointers.clear();
Checks.clear();
CheckingGroups.clear();
}

/// Insert a pointer and calculate the start and end SCEVs.
Expand Down Expand Up @@ -535,6 +537,8 @@ class RuntimePointerChecking {
/// This flag indicates if we need to add the runtime check.
bool Need = false;

bool AlwaysFalse = false;

/// Information about the pointers that may require checking.
SmallVector<PointerInfo, 2> Pointers;

Expand Down
Loading