Skip to content

[flang] Fix typos PPC intrinsics tests (NFC) #92943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkwli merged 4 commits into from
May 28, 2024
Merged

[flang] Fix typos PPC intrinsics tests (NFC) #92943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1aaf4df
[flang] Fix typos PPC intrinsics tests (NFC)
kkwli May 21, 2024
e5f9e79
Address review comments
kkwli May 21, 2024
76100a9
Address review comments
kkwli May 22, 2024
f268393
only define LLVM
kkwli May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions flang/test/Lower/PowerPC/ppc-vec-load.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
! RUN: %flang_fc1 -flang-experimental-hlfir -triple powerpc64le-unknown-unknown -emit-llvm %s -o - | FileCheck --check-prefixes="LLVMIR","LLVMIR-LE" %s
! RUN: %flang_fc1 -triple powerpc64le-unknown-unknown -target-cpu pwr9 -emit-llvm %s -o - | FileCheck --check-prefixes="LLVMIR","LLVMIR_P9" %s
! RUN: %flang_fc1 -flang-experimental-hlfir -triple powerpc64-unknown-unknown -emit-llvm %s -o - | FileCheck --check-prefixes="LLVMIR","LLVMIR-BE" %s
! REQUIRES: target=powerpc{{.*}}

Expand Down
2 changes: 1 addition & 1 deletion flang/test/Lower/PowerPC/ppc-vec-shift-be-le.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64le-unknown-linux -o - | FileCheck --check-prefixes="CHECK" %s
! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64le-unknown-linux -o - | FileCheck --check-prefixes="LLVMIR" %s
Copy link
Contributor

@klensy klensy May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this makes CHECK prefixes unused? For example, on 10 line.

Copy link
Collaborator Author

@kkwli kkwli May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. I will update it. Thanks.

Copy link
Contributor

@klensy klensy May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While currently CHECK-LABEL is allowed check prefix, this soon can be not (#92735). Plus this converts https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-label-directive to simple prefix(or not? Linked pr should fix that).

Copy link
Collaborator Author

@kkwli kkwli May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. I think I'd better use another prefix.

Copy link
Contributor

@klensy klensy May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm losing confidence in my understanding how different prefixes works between them: in case of

FOO-LABEL: xxx
BAR: yyy
...
FOO2-LABEL: zzz

will BAR me matched between FOO and FOO2 or not? idk.

Anyway, in 76100a9 you defined prefixes ending with -LABEL, but they should be LLVM, i guess. So you need to change only definitions.

Copy link
Collaborator Author

@kkwli kkwli May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, in 76100a9 you defined prefixes ending with -LABEL, but they should be LLVM, i guess. So you need to change only definitions

Sorry, I don't quite understand. Did you mean if I specify LLVM in --check-prefixes, LLVM-LABEL will be effective?

Copy link
Contributor

@klensy klensy May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should start working as directive LABEL, if i understand correct.

Copy link
Collaborator Author

@kkwli kkwli May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I push a commit to fix that.

!
! RUN: %flang_fc1 -flang-experimental-hlfir -emit-llvm %s -triple ppc64-unknown-aix -o - | FileCheck --check-prefixes="BE-LLVMIR" %s
! REQUIRES: target=powerpc{{.*}}
Expand Down