Skip to content

clang/utils/TableGen/ClangAttrEmitter.cpp: 2 * pointless copy ? (#94372) #94414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

clang/utils/TableGen/ClangAttrEmitter.cpp: 2 * pointless copy ? (#94372) #94414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clang/utils/TableGen/ClangAttrEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,8 @@ namespace {

public:
DefaultSimpleArgument(const Record &Arg, StringRef Attr,
std::string T, int64_t Default)
: SimpleArgument(Arg, Attr, T), Default(Default) {}
const std::string &T, int64_t Default)
: SimpleArgument(Arg, Attr, T), Default(Default) {}

void writeAccessors(raw_ostream &OS) const override {
SimpleArgument::writeAccessors(OS);
Expand Down Expand Up @@ -4994,7 +4994,7 @@ class SpellingList {
return Spellings[(size_t)K];
}

void add(const Record &Attr, FlattenedSpelling Spelling) {
void add(const Record &Attr, const FlattenedSpelling &Spelling) {
SpellingKind Kind =
StringSwitch<SpellingKind>(Spelling.variety())
.Case("GNU", SpellingKind::GNU)
Expand Down