Add an artifact containing the libc++ headers + libraries. #94465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This artifact is only added for the Clang C++26 configuration. The idea is to use these artifacts in other bits of the workflows, or in other tools outside of github (I'm imagining a compiler explorer instance that allows comparing the libc++ in the pull request with the head version) To be more concrete, one use case is "testing as we ship". Currently all of the workflows build the library using the same compiler (and sometimes dialect?) that they test with. This isn't representative to how libc++ is built and used in the wild. We should consider if we want to build the library once, in a blessed configuration, and then tests it against the battery of compilers & configurations we support. Right now, this is just an experiment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This artifact is only added for the Clang C++26 configuration.
The idea is to use these artifacts in other bits of the workflows,
or in other tools outside of github (I'm imagining a compiler explorer
instance that allows comparing the libc++ in the pull request with
the head version)
To be more concrete, one use case is "testing as we ship". Currently
all of the workflows build the library using the same compiler
(and sometimes dialect?) that they test with. This isn't representative
to how libc++ is built and used in the wild. We should consider
if we want to build the library once, in a blessed configuration,
and then tests it against the battery of compilers & configurations
we support.
Right now, this is just an experiment.