Skip to content

[lldb][test] Add tests for alignof on class with overlapping bases #97068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2024
+97 −10
Merged

[lldb][test] Add tests for alignof on class with overlapping bases #97068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c924c8
[lldb][test] Add tests for alignof on class with overlapping bases
Michael137 Jun 28, 2024
cbbd6cc
fixup! move CHECKs closer to their relevant static_asserts
Michael137 Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions lldb/test/Shell/SymbolFile/DWARF/no_unique_address-base-alignment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// XFAIL: *

// RUN: %clangxx_host -gdwarf -o %t %s
// RUN: %lldb %t \
// RUN: -o "expr alignof(OverlappingDerived)" \
// RUN: -o "expr sizeof(OverlappingDerived)" \
// RUN: -o exit | FileCheck %s

// CHECK: (lldb) expr alignof(OverlappingDerived)
// CHECK-NEXT: ${{.*}} = 4
Copy link
Collaborator

@dwblaikie dwblaikie Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to put the checks next to the static_asserts?

Copy link
Member Author

@Michael137 Michael137 Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, done

// CHECK: (lldb) expr sizeof(OverlappingDerived)
// CHECK-NEXT: ${{.*}} = 4

struct Empty {};

struct OverlappingBase {
[[no_unique_address]] Empty e;
};
static_assert(sizeof(OverlappingBase) == 1);
static_assert(alignof(OverlappingBase) == 1);

struct Base {
int mem;
};

struct OverlappingDerived : Base, OverlappingBase {};
static_assert(alignof(OverlappingDerived) == 4);
static_assert(sizeof(OverlappingDerived) == 4);

int main() { OverlappingDerived d; }
41 changes: 41 additions & 0 deletions lldb/test/Shell/SymbolFile/DWARF/packed-alignof.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// XFAIL: *
//
// RUN: %clangxx_host -gdwarf -o %t %s
// RUN: %lldb %t \
// RUN: -o "expr alignof(base)" \
// RUN: -o "expr alignof(packed_base)" \
// RUN: -o "expr alignof(derived)" \
// RUN: -o "expr sizeof(derived)" \
// RUN: -o exit | FileCheck %s

// CHECK: (lldb) expr alignof(base)
// CHECK-NEXT: ${{.*}} = 4
// CHECK: (lldb) expr alignof(packed_base)
// CHECK-NEXT: ${{.*}} = 1
// CHECK: (lldb) expr alignof(derived)
// CHECK-NEXT: ${{.*}} = 2
// CHECK: (lldb) expr sizeof(derived)
// CHECK-NEXT: ${{.*}} = 16

struct __attribute__((packed)) packed {
int x;
char y;
int z;
} g_packed_struct;

// LLDB incorrectly calculates alignof(base)
struct foo {};
struct base : foo { int x; };
static_assert(alignof(base) == 4);

// LLDB incorrectly calculates alignof(packed_base)
struct __attribute__((packed)) packed_base { int x; };
static_assert(alignof(packed_base) == 1);

struct derived : packed, packed_base {
short s;
} g_derived;
static_assert(alignof(derived) == 2);
static_assert(sizeof(derived) == 16);

int main() {}
14 changes: 14 additions & 0 deletions lldb/test/Shell/SymbolFile/DWARF/packed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// RUN: -o "expr sizeof(packed)" \
// RUN: -o "expr alignof(packed_and_aligned)" \
// RUN: -o "expr sizeof(packed_and_aligned)" \
// RUN: -o "expr alignof(derived)" \
// RUN: -o "expr sizeof(derived)" \
// RUN: -o exit | FileCheck %s

// CHECK: (lldb) expr alignof(packed)
Expand All @@ -16,6 +18,11 @@
// CHECK: (lldb) expr sizeof(packed_and_aligned)
// CHECK-NEXT: ${{.*}} = 16

// CHECK: (lldb) expr alignof(derived)
// CHECK-NEXT: ${{.*}} = 1
// CHECK: (lldb) expr sizeof(derived)
// CHECK-NEXT: ${{.*}} = 13

struct __attribute__((packed)) packed {
int x;
char y;
Expand All @@ -32,4 +39,11 @@ struct __attribute__((packed, aligned(16))) packed_and_aligned {
static_assert(alignof(packed_and_aligned) == 16);
static_assert(sizeof(packed_and_aligned) == 16);

struct __attribute__((packed)) packed_base { int x; };
static_assert(alignof(packed_base) == 1);

struct derived : packed, packed_base {} g_derived;
static_assert(alignof(derived) == 1);
static_assert(sizeof(derived) == 13);

int main() {}