Skip to content

[MLIR][OpenMP] Refactor translation of omp.loop_nest #98336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[MLIR][OpenMP] Refactor translation of omp.loop_nest #98336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2144,6 +2144,12 @@ void LoopNestOp::gatherWrappers(
wrappers.push_back(wrapper);
parent = parent->getParentOp();
}

// omp.parallel can be misidentified as a loop wrapper when it's not taking
// that role but it contains no other operations in its region (e.g. parallel
// do/for).
if (llvm::isa<omp::ParallelOp>(wrappers.back()))
Copy link
Member

@Meinersbur Meinersbur Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isa is one of the definitions that is also imported into the mlir namespace

Suggested change
if (llvm::isa<omp::ParallelOp>(wrappers.back()))
if (isa<omp::ParallelOp>(wrappers.back()))

wrappers.pop_back();
}

//===----------------------------------------------------------------------===//
Expand Down
Loading