Skip to content

Conversation

@labrinea
Copy link
Contributor

@labrinea labrinea commented Mar 24, 2025

@labrinea labrinea requested a review from jroelofs March 24, 2025 12:49
@labrinea labrinea merged commit 1592d36 into llvm:main Mar 26, 2025
1 check passed
@labrinea labrinea deleted the fmv-add-test-for-cssc branch March 26, 2025 11:57
@akorb
Copy link

akorb commented Aug 28, 2025

Since this PR I'm getting the error message:

FAILED: SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o
/home/korb/src/test-suite-test/test-suite-build/tools/timeit --summary SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o.time /usr/bin/clang-20 -DNDEBUG  -O3   -w -Werror=date-time --rtlib=compiler-rt -MD -MT SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o -MF SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o.d -o SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o -c /home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:363:1: error: redefinition of 'check_cssc'
  363 | CHECK(cssc, cssc, cssc, false, {
      | ^
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:37:17: note: expanded from macro 'CHECK'
   37 |     static void check_##FN_NAME_SUFFIX(void) { \
      |                 ^
<scratch space>:143:1: note: expanded from here
  143 | check_cssc
      | ^
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:363:1: note: previous definition is here
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:27:17: note: expanded from macro 'CHECK'
   27 |     static void check_##FN_NAME_SUFFIX(void) { \
      |                 ^
<scratch space>:141:1: note: expanded from here
  141 | check_cssc
      | ^
1 error generated.

Compiling with

cmake -DCMAKE_CXX_COMPILER=/usr/bin/clang++-20 -DCMAKE_C_COMPILER=/usr/bin/clang-20 \                                       1133 1 pts/14 ~/src/test-suite-test/test-suite-build korb@arm01 25-08-28 16:14:38
        -G Ninja -C../llvm-test-suite/cmake/caches/O3.cmake \
        ../llvm-test-suite
ninja

@labrinea
Copy link
Contributor Author

Since this PR I'm getting the error message:

FAILED: SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o
/home/korb/src/test-suite-test/test-suite-build/tools/timeit --summary SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o.time /usr/bin/clang-20 -DNDEBUG  -O3   -w -Werror=date-time --rtlib=compiler-rt -MD -MT SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o -MF SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o.d -o SingleSource/UnitTests/AArch64/CMakeFiles/aarch64-acle-fmv-features.dir/acle-fmv-features.c.o -c /home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:363:1: error: redefinition of 'check_cssc'
  363 | CHECK(cssc, cssc, cssc, false, {
      | ^
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:37:17: note: expanded from macro 'CHECK'
   37 |     static void check_##FN_NAME_SUFFIX(void) { \
      |                 ^
<scratch space>:143:1: note: expanded from here
  143 | check_cssc
      | ^
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:363:1: note: previous definition is here
/home/korb/src/test-suite-test/llvm-test-suite/SingleSource/UnitTests/AArch64/acle-fmv-features.c:27:17: note: expanded from macro 'CHECK'
   27 |     static void check_##FN_NAME_SUFFIX(void) { \
      |                 ^
<scratch space>:141:1: note: expanded from here
  141 | check_cssc
      | ^
1 error generated.

Compiling with

cmake -DCMAKE_CXX_COMPILER=/usr/bin/clang++-20 -DCMAKE_C_COMPILER=/usr/bin/clang-20 \                                       1133 1 pts/14 ~/src/test-suite-test/test-suite-build korb@arm01 25-08-28 16:14:38
        -G Ninja -C../llvm-test-suite/cmake/caches/O3.cmake \
        ../llvm-test-suite
ninja

Feature cssc was not supported in clang-20: https://godbolt.org/z/dWodevxaW

The 20.x branch of the llvm-test-suite doesn't have this test: https://github.com/llvm/llvm-test-suite/blob/release/20.x/SingleSource/UnitTests/AArch64/acle-fmv-features.c

@akorb
Copy link

akorb commented Aug 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants