[CI] Upstream terraform infrastructure #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch contains the terraform configuration for the premerge infrastructure. Actually applying changes requires someone from within Google with access to the GCP project to apply the changes, but the entire infrastructure is described within the TF in this patch. Co-authored-by: Nathan Gauër <[email protected]>
boomanaiden154
requested review from
Endilll,
Keenuts,
joker-eph and
lnihlen
Contributor
Author
Keenuts
approved these changes
Nov 29, 2024
Contributor
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
LGTM from the GCP/cluster point of view.
Letting the others approve/review for repo organization, etc
joker-eph
reviewed
Nov 29, 2024
Contributor
|
That LGTM in general, I'm not a terraform expert though so I wouldn't be able to to spot any subtle issue there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch contains the terraform configuration for the premerge infrastructure. Actually applying changes requires someone from within Google with access to the GCP project to apply the changes, but the entire infrastructure is described within the TF in this patch.
Co-authored-by: Nathan Gauër [email protected]