sphinx: install requirements.txt #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdesaulniers
commented
Dec 17, 2024
boomanaiden154
approved these changes
Dec 17, 2024
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM.
Although @gkistanova will need to confirm whether or not this will run properly on the bot.
marcauberer
approved these changes
Dec 17, 2024
Member
Author
|
I'm planning to be on vacation for 2 weeks (plus tomorrow). So merging this now, as I only have today to work through issues if it's not perfect. |
Member
Author
|
The bot's build queue looks stuck to me: https://lab.llvm.org/buildbot/#/builders/178 🤷 |
Member
Author
|
Builds are back to green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: llvm/llvm-project#120274
Link: llvm/llvm-project#120319