Skip to content

[BOLT] Add sanity check for frozen llvm-bolt #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2025
Merged

[BOLT] Add sanity check for frozen llvm-bolt #487

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
faa4d58
[BOLT] Add sanity check for frozen llvm-bolt
paschalis-mpeis Jun 28, 2025
352259d
Use nice when running tests
paschalis-mpeis Jun 28, 2025
9f1fea2
Addressing reviewers
paschalis-mpeis Jun 30, 2025
8e2ded2
Add more comments in code.
paschalis-mpeis Jul 2, 2025
114db12
Drop -s from llvm-lit
paschalis-mpeis Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions zorg/buildbot/builders/BOLTBuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,16 @@ def getBOLTCmakeBuildFactory(
haltOnFailure=False,
flunkOnFailure=False,
env=env),
ShellCommand(
name='llvm-bolt-version-check',
command=(f"{boltNew} --version"),
description=('Check that llvm-bolt binary passes a simple test'
'before proceeding with testing.'),
descriptionDone=["llvm-bolt --version"],
haltOnFailure=True,
flunkOnFailure=True,
maxTime=30,
env=env),
# Validate that NFC-mode comparison is meaningful by checking:
# - the old and new binaries exist
# - no unique IDs are embedded in the binaries
Expand All @@ -154,6 +164,7 @@ def getBOLTCmakeBuildFactory(
haltOnFailure=False,
warnOnFailure=True,
warnOnWarnings=True,
maxTime=20,
decodeRC={0: SUCCESS, 1: FAILURE, 2: WARNINGS},
descriptionDone=["NFC-Mode Validation"],
env=env),
Expand All @@ -177,7 +188,7 @@ def getBOLTCmakeBuildFactory(
# relevant source code changes are detected.
LitTestCommand(
name='nfc-check-bolt',
command=["ninja", "check-bolt"],
command=("LIT_OPTS='-j2' nice -n 5 ninja check-bolt"),
description=["running", "NFC", "check-bolt"],
descriptionDone=["NFC", "check-bolt", "completed"],
warnOnFailure=True,
Expand All @@ -188,8 +199,7 @@ def getBOLTCmakeBuildFactory(
# Run out-of-tree large tests if the llvm-bolt binary has changed.
LitTestCommand(
name='nfc-check-large-bolt',
command=['bin/llvm-lit', '-sv', '-j2',
'tools/bolttests'],
command=('nice -n 5 bin/llvm-lit -sv -j2 tools/bolttests'),
description=["running", "NFC", "check-large-bolt"],
descriptionDone=["NFC", "check-large-bolt", "completed"],
warnOnFailure=True,
Expand Down