Skip to content

[GreenDragon] Duplicate and templatize clang-stage2-Rthinlto for bisection #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jroelofs
Copy link
Contributor

@jroelofs jroelofs commented Aug 2, 2025

The new approach modularizes and templatizes the job so that we can automatically bisect build failures down to the commit responsible for them. The new jobs written in this style use the name-inspecting symlink trick that clang itself uses to determine driver mode, for organizational simplicity and deduplication of configuration. For now, I am duplicating the job wholesale, until we're comfortable with replacing all of the existing clang-* jobs with this style.

As part of this, we're adding a templatized bisection job and corresponding runner. Currently, these cooperate to bisect the clang-stage2-Rthinlto-v2 job's failures, but going forward we should be set up to re-use that for any other job's bisection needs. We will also be well set up to add a test bisection runner, which could leverage the artifacts saved to S3 as a caching mechanism to speed up the search.

…ction

The new approach modularizes and templatizes the job so that we can
automatically bisect build failures down to the commit responsible for them. The
new jobs written in this style use the name-inspecting symlink trick that clang
itself uses to determine driver mode, for organizational simplicity and
deduplication of configuration. For now, I am duplicating the job wholesale,
until we're comfortable with replacing all of the existing clang-* jobs with
this style.

As part of this, we're adding a templatized bisection job and corresponding
runner. Currently, these cooperate to bisect the clang-stage2-Rthinlto-v2 job's
failures, but going forward we should be set up to re-use that for any other
job's bisection needs. We will also be well set up to add a test bisection
runner, which could leverage the artifacts saved to S3 as a caching mechanism to
speed up the search.
@tomershafir
Copy link

Initial thoughts:

  • The pipeline declarations in pipeline() and createTemplatedPipeline() are very similar. Given that we want to enable composability, consistency and reusability, maybe we should parametrize both into a single pipeline.
  • Similarly, I think we should align the design of bisection to the one of Clang jobs. Extract a parametrized BisectBuilder that is called post a Clang job. The builder would create the trigger pipeline (build-bisect), embed the utils, and possibly call a parametrized ClangBuilder (instead build-bisect-run). Currently, the call graph is: Clang job -> build-bisect -> bisect utils -> build-bisect-run which can be simplified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants