Skip to content

Move cast member function deprecation to completed refactorings #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2025
Merged

Move cast member function deprecation to completed refactorings #222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfa4ab8
Move cast member function deprecation to completed refactorings
kuhar Apr 27, 2025
08856a4
Reword
kuhar Apr 27, 2025
60d7b77
Format
kuhar Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions website/content/deprecation/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,6 @@ up with MLIR development.

## Deprecated

### Use the free function variants for `dyn_cast`/`cast`/`isa`/...

When casting attributes or type, use the free functions variants, e.g.,
`dyn_cast<T>(x)`, `isa<T>(x)`, etc. Use of the cast methods variants (e.g.,
`x.dyn_cast<T>()`) should be avoided in new code as we'll remove these
methods in the future.
[Discussion on Discourse](https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443)

### Use `matchAndRewrite` instead of `match` / `rewrite`

The `match` and `rewrite` functions of `RewritePattern` and `ConversionPattern`
Expand Down Expand Up @@ -108,3 +100,14 @@ been implemented in upstream MLIR or any known downstream projects. Due to this
lack of use, it was decided that the operation should be removed.

[Discussion on Discourse](https://discourse.llvm.org/t/rfc-should-vector-reshape-be-removed/80478)

## LLVM 21

### Use the free function variants for `dyn_cast`/`cast`/`isa`/...

When casting attributes or type, use the free functions variants, e.g.,
`dyn_cast<T>(x)`, `isa<T>(x)`, etc. Use of the cast methods variants (e.g.,
`x.dyn_cast<T>()`) should be avoided in new code as we removed these
methods in https://github.com/llvm/llvm-project/pull/135556.

[Discussion on Discourse](https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443)