Skip to content

Enable implicit binding tests for Clang-DXC #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

Enable implicit binding tests for Clang-DXC #212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98cc893
Enable implicit binding tests for Clang-DXC
hekota May 29, 2025
c07e007
It's Vulkan!
hekota May 30, 2025
2ebe7f1
Disable simple-resources.test for Metal; update links
hekota May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/Feature/ImplicitBindings/all-implicit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ DescriptorSets:
...
#--- end

# UNSUPPORTED: Clang
# Clang's Vulcan implicit binding is not yet implemented.
# UNSUPPORTED: Clang-Vulkan

# CBuffer bindings seem to be broken under metal
# https://github.com/llvm-beanz/offload-test-suite/issues/55
Expand Down
6 changes: 3 additions & 3 deletions test/Feature/ImplicitBindings/simple-resources.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ DescriptorSets:
...
#--- end

# UNSUPPORTED: Clang
# Clang's Vulcan implicit binding is not yet implemented.
# UNSUPPORTED: Clang-Vulkan

# DXC's vulkan backend doesn't drop unused bindings, so it isn't possible to
# specify descriptor sets that are valid for both DirectX and Vulkan there.
# UNSUPPORTED: DXC-Vulkan

# RUN: split-file %s %t
# RUN: %if !Vulkan %{ %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-scalar-layout -Fo %t.o %t/source.hlsl %}
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

# CHECK: Name: BufD
Expand Down
Loading