Remove XFAIL on passing WaveGetLaneIndex test #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spall
approved these changes
Jul 8, 2025
Collaborator
spall
left a comment
spall
left a comment
There was a problem hiding this comment.
LGTM and we appear to have found the commit that fixed it.
bogner
approved these changes
Jul 8, 2025
Collaborator
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
LGTM. Please update the commit message to mention that this was fixed by llvm/llvm-project#144371
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a test that has begun to pass unexpectedly.
The test is passing due to this commit: llvm/llvm-project#144371
To prevent other PRs from being blocked, this test will be expected to pass from now on.
Fixes #283