Skip to content

Add test for asfloat #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

Add test for asfloat #297

merged 2 commits into from
Aug 12, 2025

Conversation

spall
Copy link
Collaborator

@spall spall commented Jul 23, 2025

Add test for asfloat for float, int, and uint inputs.
Closes #176

Copy link
Contributor

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit

Out2[1] = float4(asfloat(In2[1].xyz), asfloat(In2[1].w));
Out2[2] = float4(asfloat(In2[2].xy), asfloat(In2[2].zw));
Out2[3] = asfloat(int4(-1, 0, 50, 2147483647));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace seems a little messed up

Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the awkward whitespace @bob80905 pointed out, looks good.

@spall spall merged commit 1a9166e into llvm:main Aug 12, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for asfloat
3 participants