Skip to content

Add dot tests #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2025
Merged

Add dot tests #318

merged 6 commits into from
Aug 11, 2025

Conversation

kmpeng
Copy link
Contributor

@kmpeng kmpeng commented Aug 6, 2025

Closes #124.

Adds tests for dot testing 16 bit int types, half, 32 bit types, 64 bit int types, and double (only supports scalar double not vector). Didn't use the HLK test inputs because it was testing 9 inputs for each of vector sizes 2-4, and the tests were mostly for nans, infs, and denorms.

@kmpeng kmpeng marked this pull request as ready for review August 7, 2025 00:26
Copy link
Contributor

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah accident, I'll approve after the tolerance is updated

Copy link
Collaborator

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kmpeng kmpeng merged commit 8b04ac1 into llvm:main Aug 11, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for dot
3 participants