Skip to content

Adjust hyperbolic trig functions to use ULP rules #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 12, 2025
Merged

Adjust hyperbolic trig functions to use ULP rules #342

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2454938
Adjust hyperbolic trig functions to use ULP rules
llvm-beanz Aug 10, 2025
94482ab
Adjust 32-bit ULP to widen
llvm-beanz Aug 10, 2025
e8db81a
Fix tanh ULP
llvm-beanz Aug 10, 2025
d7a77c1
Adjusting tanh range
llvm-beanz Aug 10, 2025
1657058
Give a very big range on tanh
llvm-beanz Aug 11, 2025
bc1e281
Try smaller ULP with /Gis
llvm-beanz Aug 11, 2025
38d84a0
Go back to 120 for tanh
llvm-beanz Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/Feature/HLSLLib/cosh.32.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Buffers:
# NaN, Inf, 1.0, 1.0, 1.0, 1.0, Inf, 1.543081, 1.543081,
Results:
- Result: Test1
Rule: BufferFloatEpsilon
Epsilon: 0.0008
Rule: BufferFloatULP
ULPT: 4
Actual: Out
Expected: ExpectedOut
DescriptorSets:
Expand Down
4 changes: 2 additions & 2 deletions test/Feature/HLSLLib/sinh.16.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Buffers:
# NaN, -Inf, 0.0, 0.0, 0.0, 0.0, Inf, 1.175201, -1.175201,
Results:
- Result: Test1
Rule: BufferFloatEpsilon
Epsilon: 0.0008
Rule: BufferFloatULP
ULPT: 2
Actual: Out
Expected: ExpectedOut
DescriptorSets:
Expand Down
4 changes: 2 additions & 2 deletions test/Feature/HLSLLib/sinh.32.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Buffers:
# NaN, -Inf, 0.0, 0.0, 0.0, 0.0, Inf, 1.175201, -1.175201,
Results:
- Result: Test1
Rule: BufferFloatEpsilon
Epsilon: 0.0008
Rule: BufferFloatULP
ULPT: 4
Actual: Out
Expected: ExpectedOut
DescriptorSets:
Expand Down
4 changes: 2 additions & 2 deletions test/Feature/HLSLLib/tanh.16.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Buffers:
# -0.0, 0.0, 0.761594, -0.761594, -0.0, 0.0, 0.761594, -0.761594, -0.0, 0.0, 0.761594, -0.761594,
Results:
- Result: Test1
Rule: BufferFloatEpsilon
Epsilon: 0.0008
Rule: BufferFloatULP
ULPT: 5
Actual: Out
Expected: ExpectedOut
DescriptorSets:
Expand Down
6 changes: 3 additions & 3 deletions test/Feature/HLSLLib/tanh.32.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ Buffers:
Data: [ -0.0, 0.0, 0.761594, -0.761594, -0.0, 0.0, 0.761594, -0.761594, -0.0, 0.0, 0.761594, -0.761594]
Results:
- Result: Test1
Rule: BufferFloatEpsilon
Epsilon: 0.0008
Rule: BufferFloatULP
ULPT: 5
Actual: Out
Expected: ExpectedOut
DescriptorSets:
Expand All @@ -61,5 +61,5 @@ DescriptorSets:


# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %dxc_target -T cs_6_5 -Gis -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o
Loading