Skip to content

[NFC] Simplify WaveActiveMax test #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[NFC] Simplify WaveActiveMax test #347

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
316ce4d
[NFC] Simplify WaveActiveMax test
llvm-beanz Aug 12, 2025
951ec37
Oops
llvm-beanz Aug 12, 2025
24c1f51
Add WARP handling
llvm-beanz Aug 12, 2025
85125a0
Tweaking handling of identity values
llvm-beanz Aug 12, 2025
2673532
Fix conditional
llvm-beanz Aug 12, 2025
e85239b
Got it this time..
llvm-beanz Aug 12, 2025
4bb56e7
Fixing nan check
llvm-beanz Aug 12, 2025
9b2e071
Ugh...
llvm-beanz Aug 12, 2025
93c3a03
This should get it going
llvm-beanz Aug 13, 2025
882e764
Rename test
llvm-beanz Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 15 additions & 22 deletions test/WaveOps/WaveActiveMax.test → ...WaveOps/EdgeConditions/WaveActiveMax.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ RWStructuredBuffer<float> Infs : register(u1);
RWStructuredBuffer<float> NegInfs : register(u2);
RWStructuredBuffer<float> Mix : register(u3);

[numthreads(32,1,1)]
void main(uint3 TID : SV_GroupThreadID) {
Nans[TID.x % 8] = WaveActiveMax(Nans[TID.x % 8]);
Infs[TID.x % 8] = WaveActiveMax(Infs[TID.x % 8]);
NegInfs[TID.x % 8] = WaveActiveMax(NegInfs[TID.x % 8]);
Mix[TID.x % 8] = WaveActiveMax(Mix[TID.x % 8]);
[numthreads(4,1,1)]
void main(uint GID : SV_GroupIndex) {
Nans[GID] = WaveActiveMax(Nans[GID]);
Infs[GID] = WaveActiveMax(Infs[GID]);
NegInfs[GID] = WaveActiveMax(NegInfs[GID]);
Mix[GID] = WaveActiveMax(Mix[GID]);
}
//--- pipeline.yaml

Expand Down Expand Up @@ -66,11 +66,10 @@ DescriptorSets:
#--- end

# RUN: split-file %s %t
# RUN: %if !Vulkan %{ %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.2 -Fo %t.o %t/source.hlsl %}
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

# The behavior of this operation is consistent on Metal, so the test verifies that behavior.
# RUN: %dxc_target -T cs_6_0 -Gis -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s \
# RUN: %if Metal %{ --check-prefixes=CHECK,NAN %} \
# RUN: %else %{ --check-prefixes=CHECK,NO_NAN %}

# The SPIR-V Spec for OpGroupNonUniformFMax says:
# > From the set of Value(s) provided by active invocations within a subgroup,
Expand All @@ -80,27 +79,21 @@ DescriptorSets:

# This makes Vulkan undefined for cases where all values are nan.

# Also SPIR-V states:
# > The identity I for Operation is -INF.

# This makes it defined that any lane value of -INF is ignored.
# DirectX driver implementations seem to match SPIR-V.

# DirectX driver implementations seem to match SPIR-V, except WARP, which does
# not treat -INF as an identity.
# Metal also is consistent except that it preserves NaN.

# XFAIL: DirectX-WARP

# CHECK: Name: Nans
# CHECK-NEXT: Format: Float32
# METAL-NEXT: Data: [ 0, 0, 0, 0 ]
# DX-NEXT: Data:
# VULKAN-NEXT: Data:
# NAN-NEXT: Data: [ nan, nan, nan, nan ]
# NO_NAN-NEXT: Data:
# CHECK: Name: Infs
# CHECK-NEXT: Format: Float32
# CHECK-NEXT: Data: [ inf, inf, inf, inf ]
# CHECK: Name: NegInfs
# CHECK-NEXT: Format: Float32
# CHECK-NEXT: Data: [ 0, 0, 0, 0 ]
# CHECK-NEXT: Data: [ -inf, -inf, -inf, -inf ]
# CHECK: Name: Mix
# CHECK-NEXT: Format: Float32
# CHECK-NEXT: Data: [ inf, inf, inf, inf ]