Remove XFAILs from select tests
#496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob80905
approved these changes
Nov 5, 2025
inbelic
approved these changes
Nov 5, 2025
Contributor
|
The hlsl-clang-vk test failure is relevant here before merging |
Contributor
Author
|
Hm seems like a regression in the SPIRV backend that's unrelated to my changes - I tried removing the non-bool condition tests and also reverting the hlsl_alias_intrinsics.h code back to how it was before the bug was fixed, but it's still crashing. Will file a bug and XFAIL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were fixed by llvm/llvm-project#166279.