Skip to content

Conversation

@mgehre-amd
Copy link
Contributor

Same as llvm/llvm-project#123303 upstream

@mgehre-amd mgehre-amd marked this pull request as draft February 24, 2025 14:16
@makslevental
Copy link
Collaborator

makslevental commented Feb 24, 2025

Is this Ready for review? You didn't click that button but you assigned to me.... Anyway I haven't reviewed in here (torch-mlir) in quite a long time but I guess it's okay since I reviewed/approved the upstream patch. If you're ready I can stamp.

@mgehre-amd mgehre-amd marked this pull request as ready for review February 25, 2025 15:04
@mgehre-amd
Copy link
Contributor Author

Is this Ready for review? You didn't click that button but you assigned to me.... Anyway I haven't reviewed in here (torch-mlir) in quite a long time but I guess it's okay since I reviewed/approved the upstream patch. If you're ready for ready I can stamp.

Thanks, I'm ready now!

Copy link
Collaborator

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let me know if you need me to merge.

@mgehre-amd mgehre-amd merged commit 9de187b into llvm:main Feb 25, 2025
3 checks passed
@mgehre-amd mgehre-amd deleted the matthias.asan branch February 25, 2025 16:10
mgehre-amd added a commit that referenced this pull request Feb 26, 2025
ubsan detected
'lib/Dialect/TorchConversion/Transforms/UnpackQuantTensor.cpp:109:21:
runtime error: left shift of negative value -16' and asan detected
`memcpy` with nullptr when we passed and empty vector with `.data() ==
nullptr` to mlirOperationStateAddResults.

Detected using #4046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants