-
Notifications
You must be signed in to change notification settings - Fork 639
Update docs and .env file to reflect PYTHONPATH variability #4332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update scripts and readme docs to grab PYTHONPATH from env file. Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with what write_env_file.sh
is / was doing but it is bad practice to write files during configure or build to the source directory. Any other place this could go to?
Signed-off-by: zjgarvey <[email protected]>
…-tree dir. Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
This reverts commit 54a63f8.
This reverts commit 09de7e5.
This reverts commit 3c9a1f8.
This reverts commit 6978352.
This reverts commit 493696f.
This reverts commit 8fde78e.
.env
file directly during cmake build…ix_cmake_python_issues
This updates the docs and
build_tools/write_env_file.sh
to correctly identify thePYTHONPATH
based on in-tree vs. out-of-tree builds.Additionally, I've updated various build configure commands to include a directive to align
Python
withPython3
, since having conflicting versions of python can cause issues when not explicitly setting both to the same python executable.Resolves #4331