Skip to content

[e2e] : Change default to fx_importer. #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −6
Open

[e2e] : Change default to fx_importer. #4387

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60fc068
[e2e] : Change default to fx_importer.
sahas3 Nov 24, 2025
3aecdaa
[e2e] : Update doc to point to fx_importer_tosa.
sahas3 Nov 24, 2025
1ffc460
[Task] : Update help text for e2e.main
sahas3 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,8 @@ The following assumes you are in the `projects/pt1` directory:
./tools/e2e_test.sh
# Run tests that match the regex `Conv2d`, with verbose errors.
./tools/e2e_test.sh --filter Conv2d --verbose
# Run tests on the TOSA backend.
./tools/e2e_test.sh --config tosa
# Run tests on the TOSA backend via fx_importer path
./tools/e2e_test.sh --config fx_importer_tosa
```

Alternatively, you can run the tests via Python directly:
Expand Down
2 changes: 1 addition & 1 deletion projects/pt1/e2e_testing/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def _get_argparse():
"-c",
"--config",
choices=config_choices,
default="linalg",
default="fx_importer",
Copy link
Contributor

@hariprasadravi hariprasadravi Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this should have been named fx_importer_linalg to make it consistent with fx_importer_tosa and stablehlo. Will it be very invasive?

Copy link
Member Author

@sahas3 sahas3 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, tosa/stablehlo paths were introduced after the linalg backend path. So that's probably why the names are the way they are currently. I think changing fx_importer to fx_importer_linalg may cause issues for downstream users.

help=f"""
Meaning of options:
"linalg": run through torch-mlir"s default Linalg-on-Tensors backend.
Expand Down
Loading