Bump Bazel to 8.4.2 and fix Bazel build #4438
Draft
+64
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkocmathla
commented
Jan 23, 2026
| @@ -1,5 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -e | |||
Contributor
Author
There was a problem hiding this comment.
This makes it so the script exits if the docker build command fails, instead of falling through to the docker run command on failure.
tkocmathla
commented
Jan 24, 2026
| @@ -1,5 +1,5 @@ | |||
| ARG BASE_IMG=ubuntu:22.04 | |||
| FROM ${BASE_IMG} as dev-base | |||
| FROM ${BASE_IMG} AS dev-base | |||
Contributor
Author
There was a problem hiding this comment.
This just silences a warning about a case mismatch between the FROM and as keywords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Bazel build by bringing Torch-MLIR's Bazel version up to date with the LLVM one (8.4.2) at the LLVM submodule's pinned commit.
In order to get the build and tests passing, I had to make some small tweaks to the main
BUILD.bazelfile, and add a few explicit dependencies from Bazel Central. Note that this PR makes no attempt to migrate to the bzlmod system--that should be reserved for a separate effort--and so a few options are required in the.bazelrcto keep the legacy behavior for now.