[Root Signatures] Fix default values for Descriptor Range Flags and Root Descriptor Flags in Version 1 #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbelic
reviewed
Jun 18, 2025
inbelic
approved these changes
Jun 24, 2025
joaosaffran
changed the title
bogner
approved these changes
Jun 25, 2025
inbelic
reviewed
Jun 25, 2025
| @@ -461,7 +461,10 @@ As specified in the grammar, '0' denotes there are no flags set. | |||
| - `RootFlags = 0` | |||
| - `ROOT_DESCRIPTOR_FLAGS` and `DESCRIPTOR_RANGE_FLAGS` | |||
| - Version 1.0: | |||
| - `DATA_VOLATILE` | |||
| - `CBV`: `DATA_VOLATILE | DESCRIPTORS_VOLATILE` | |||
There was a problem hiding this comment.
These should also be split into the different flag types. DESCRIPTORS_VOLATILE isn't a valid ROOT_DESCRIPTOR_FLAG
There was a problem hiding this comment.
@joaosaffran This does not appear to have been handled before merging.
There was a problem hiding this comment.
I will address it in a future PR
inbelic
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 4, 2025
…gnature Version (#145828) This pr updates `setDefaultFlags` in `HLSLRootSignature.h` to account for which version it should initialize the default flag values for. - Updates `setDefaultFlags` with a `Version` argument and initializes them to be compliant as described [here](llvm/wg-hlsl#297). - Updates `RootSignatureParser` to retain the `Version` and pass this into `setDefaultFlags` - Updates all uses of `setDefaultFlags` in test-cases - Adds some new unit testing to ensure behaviour is as expected and that the Parser correctly passes down the version Resolves #145820.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 4, 2025
…for Root Signature Version (#145828) This pr updates `setDefaultFlags` in `HLSLRootSignature.h` to account for which version it should initialize the default flag values for. - Updates `setDefaultFlags` with a `Version` argument and initializes them to be compliant as described [here](llvm/wg-hlsl#297). - Updates `RootSignatureParser` to retain the `Version` and pass this into `setDefaultFlags` - Updates all uses of `setDefaultFlags` in test-cases - Adds some new unit testing to ensure behaviour is as expected and that the Parser correctly passes down the version Resolves llvm/llvm-project#145820.
inbelic
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 9, 2025
…nature` (#147111) This pr resolves some discrepancies in verification during `validate` in `DXILRootSignature.cpp`. Note: we don't add a backend test for version 1.0 flag values because it treats the struct as though there is no flags value. However, this will be used when we use the verifications in the frontend. - Updates `verifyDescriptorFlag` to check for valid flags based on version, as reflected [here](llvm/wg-hlsl#297) - Add test to demonstrate updated flag verifications - Adds `verifyNumDescriptors` to the validation of `DescriptorRange`s - Add a test to demonstrate `numDescriptors` verification - Updates a number of tests that mistakenly had an invalid `numDescriptors` specified Resolves: #147107
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 9, 2025
…DXILRootSignature` (#147111) This pr resolves some discrepancies in verification during `validate` in `DXILRootSignature.cpp`. Note: we don't add a backend test for version 1.0 flag values because it treats the struct as though there is no flags value. However, this will be used when we use the verifications in the frontend. - Updates `verifyDescriptorFlag` to check for valid flags based on version, as reflected [here](llvm/wg-hlsl#297) - Add test to demonstrate updated flag verifications - Adds `verifyNumDescriptors` to the validation of `DescriptorRange`s - Add a test to demonstrate `numDescriptors` verification - Updates a number of tests that mistakenly had an invalid `numDescriptors` specified Resolves: llvm/llvm-project#147107
|
Will address this in a future PR
…On Mon, Aug 11, 2025 at 10:20 AM Finn Plummer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In proposals/0002-root-signature-in-clang.md
<#297 (comment)>:
> @@ -461,7 +461,10 @@ As specified in the grammar, '0' denotes there are no flags set.
- `RootFlags = 0`
- `ROOT_DESCRIPTOR_FLAGS` and `DESCRIPTOR_RANGE_FLAGS`
- Version 1.0:
- - `DATA_VOLATILE`
+ - `CBV`: `DATA_VOLATILE | DESCRIPTORS_VOLATILE`
@joaosaffran <https://github.com/joaosaffran> This does not appear to
have been handled before merging.
—
Reply to this email directly, view it on GitHub
<#297 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6FCIS5XEDA2TJZ4YUMIPXD3NDGFTAVCNFSM6AAAAAB7ULE5FSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMBWHEZDONBWGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is updating the spec to match DXC behaviour for Descriptor Ranges flags serialization on root signatures version 1.
DXC: https://github.com/microsoft/DirectXShaderCompiler/blob/d43d909801c185e5bad11a683a970cd23957c3c9/lib/DxilRootSignature/DxilRootSignature.cpp#L118