Skip to content

Conversation

@0xCaponte
Copy link
Contributor

@0xCaponte 0xCaponte commented Jun 16, 2023

Given the way that variationsStream is implemented, the code still calculates all permutations with repetition up to the min length, but these are no longer passed along to be processed and checked against the token. Ideal would be to replace or extend the variationsStream call but that library has not been updated in 9 years.

Closes #19

Given the way that variationsStream is implemented, the code still calculates all permutations with repetition up to the min length, but these are no longer passed along to be processed and checked against the token. Ideal would be to replace or extend the variationsStream call but that library has not been updated in 9 years.
@lmammino
Copy link
Owner

Thanks, this makes a lot of sense.

I agree that ideally, it will make sense to implement this directly in variation-stream and then update the library here.

I think the current implementation still has performance benefits (because for the items that are skipped, we don't need to test if they would work as a valid signature), even though it's not the most optimal approach...

@lmammino
Copy link
Owner

I am also thinking that another approach might be to switch to lmammino/indexed-string-variation, which should already allow us to skip entries (basically starting from the first index that corresponds to a sequence of a given minim length).

@lmammino lmammino changed the title Issue 19 - Min secret length Min secret length Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

is there any feature to skip the short length? i mean the length can custom for 7-30 characters only and skip 1-6 characters

2 participants