-
Notifications
You must be signed in to change notification settings - Fork 154
improve llm spans view #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
improve llm spans view #1061
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
461327f
llm spans
shoqqan cce4e66
little refactor
shoqqan 1927ffe
changes for shared added
shoqqan ba36867
change alignment
shoqqan b201b15
type checking in util function
shoqqan 5352847
span name fallback
shoqqan fe7fa54
center text content in timeline
shoqqan 10df28d
consistent gaps
shoqqan f9302a7
Merge branch 'dev' into feat/improve-llm-spans/LAM-999
shoqqan 6a21c39
aggregated span metrics in tree
shoqqan f22031a
fix lack of metrics
shoqqan 598b5aa
Merge remote-tracking branch 'origin/dev' into feat/improve-llm-spans…
shoqqan de9a3f7
delete unnecessary span
shoqqan 512f3fa
fix outside view of spans
shoqqan 687d9da
calculations in backend, tooltip llm name, min-width for span name
shoqqan f2f7bca
delete duplicate ref
shoqqan 5328f3e
Merge branch 'dev' into feat/improve-llm-spans/LAM-999
olzhik11 a67d6f6
feat: count current span if llm
olzhik11 29141b1
feat: address comments, llm only leaf spans
olzhik11 689c00a
feat: add aggregation to shared traces
olzhik11 4306b36
feat: add short notation
olzhik11 e47e204
Merge branch 'dev' into feat/improve-llm-spans/LAM-999
olzhik11 1afb6c8
feat: fix realtime
olzhik11 ef0c432
feat: add model
olzhik11 947f19b
small fix
olzhik11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
frontend/components/traces/trace-view/ui/span-display-tooltip.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import React, { ReactNode } from "react"; | ||
|
|
||
| import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from "@/components/ui/tooltip.tsx"; | ||
| import { cn } from "@/lib/utils.ts"; | ||
|
|
||
| interface SpanDisplayTooltipProps { | ||
| isLLM: boolean; | ||
| name: string; | ||
| children: ReactNode; | ||
| } | ||
|
|
||
| export const SpanDisplayTooltip = ({ name, isLLM, children }: SpanDisplayTooltipProps) => ( | ||
| <TooltipProvider disableHoverableContent={!isLLM}> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild>{children}</TooltipTrigger> | ||
| <TooltipContent | ||
| side="top" | ||
| className={cn("text-sm p-2 text-center border whitespace-pre-wrap text-secondary-foreground")} | ||
| > | ||
| {name} | ||
| </TooltipContent> | ||
| </Tooltip> | ||
| </TooltipProvider> | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.