-
Notifications
You must be signed in to change notification settings - Fork 178
LAM-1287: Add notification logging to ClickHouse and Slack subscription for reports #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
laminar-coding-agent
wants to merge
4
commits into
dev
Choose a base branch
from
agent/lam-1287-03cf96
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e86522f
LAM-1287: Add notification logging to ClickHouse and Slack subscripti…
olzhik11 ef478ac
fix: remove stale state in Slack channel selector for reports
olzhik11 2ff32a6
fix: use distinct notification_type category in ClickHouse logs
olzhik11 d015d79
fix: resolve workspace_id for signal alert notifications
olzhik11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| use anyhow::Result; | ||
| use clickhouse::Row; | ||
| use serde::{Deserialize, Serialize}; | ||
| use uuid::Uuid; | ||
|
|
||
| /// ClickHouse row for notification_log table. | ||
| /// Records every notification (email or Slack) sent by the system for auditing and inspection. | ||
| #[derive(Row, Serialize, Deserialize, Clone, Debug)] | ||
| pub struct CHNotificationLog { | ||
| #[serde(with = "clickhouse::serde::uuid")] | ||
| pub id: Uuid, | ||
| #[serde(with = "clickhouse::serde::uuid")] | ||
| pub workspace_id: Uuid, | ||
| #[serde(with = "clickhouse::serde::uuid")] | ||
| pub project_id: Uuid, | ||
| /// "report" or "alert" | ||
| pub notification_type: String, | ||
| /// "email" or "slack" | ||
| pub channel: String, | ||
| /// Email address or Slack channel ID | ||
| pub recipient: String, | ||
| /// Email subject or Slack message summary | ||
| pub subject: String, | ||
| /// Full HTML body (email) or JSON blocks (Slack) | ||
| pub body: String, | ||
| /// Name of the event that triggered this notification | ||
| pub event_name: String, | ||
| /// "success" or "error" | ||
| pub status: String, | ||
| /// Error message if status is "error", empty otherwise | ||
| pub error: String, | ||
| /// Millisecond-precision timestamp | ||
| pub created_at: i64, | ||
| } | ||
|
|
||
| impl CHNotificationLog { | ||
| pub fn now_millis() -> i64 { | ||
| chrono::Utc::now().timestamp_millis() | ||
| } | ||
| } | ||
|
|
||
| /// Insert notification log entries into ClickHouse. | ||
| pub async fn insert_notification_logs( | ||
| clickhouse: &clickhouse::Client, | ||
| logs: Vec<CHNotificationLog>, | ||
| ) -> Result<()> { | ||
| if logs.is_empty() { | ||
| return Ok(()); | ||
| } | ||
|
|
||
| let mut insert = clickhouse | ||
| .insert::<CHNotificationLog>("notification_log") | ||
| .await?; | ||
| insert = insert.with_option("wait_for_async_insert", "0"); | ||
|
|
||
| for log in logs { | ||
| insert.write(&log).await?; | ||
| } | ||
|
|
||
| insert | ||
| .end() | ||
| .await | ||
| .map_err(|e| anyhow::anyhow!("ClickHouse notification_log insertion failed: {:?}", e))?; | ||
|
|
||
| Ok(()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.