Refactor sync API demultiplexing logic #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demultiplexing in the sync API had become quite tangled, with the foreground thread responsible for allocating multiplexing IDs and receive queues, while the background thread handling the actual demultiplexing process. Now the sync API is using async queues for its demultiplexing, move multiplexing ID and queue management entirely to the background thread.
github-actions
bot
added
the
CLA signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demultiplexing in the sync API had become quite tangled, with the foreground thread responsible for allocating multiplexing IDs and receive queues, while the background thread handling the actual demultiplexing process.
Now the sync API is using async queues for its demultiplexing, move multiplexing ID and queue management entirely to the background thread.