Remove hard-coded image resize #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CLA signed
yagil
reviewed
Oct 22, 2025
will-lms
reviewed
Oct 22, 2025
|
|
||
|
|
||
| def custom_resize(pil_images, max_size=(1000, 1000), should_pad=True): | ||
| def custom_resize(pil_images, max_size=None, should_pad=True): |
Comment on lines
+175
to
+176
| max_image_size (Optional[int]): Maximum dimension for images (assumes square). Images will be | ||
| resized to (max_image_size, max_image_size) if they exceed this size. If None, no resizing. |
There was a problem hiding this comment.
Looking at the code in image_utils.py, I find this comment misleading. When I read it, it sounds like it will resize the image to a square, but we are actually keeping the aspect ratio and setting the longest size to this maximum.
Why not expose this as a tuple[int, int] at this level as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hard-coded image resize, in favor of an argument when making the inference request. Pass in a max image size in
demo.pyand the tests.