Open
Conversation
David-Daminelli
force-pushed
the
iq-tb
branch
2 times, most recently
from
36035a8 to
d823486
Compare
guilhermerc
requested changes
Jul 7, 2025
David-Daminelli
force-pushed
the
iq-tb
branch
4 times, most recently
from
2c06e70 to
53fa74f
Compare
David-Daminelli
force-pushed
the
iq-tb
branch
4 times, most recently
from
763e8ce to
12855e5
Compare
guilhermerc
requested changes
Jul 8, 2025
There was a problem hiding this comment.
Changes in the gc_iq_demodulator testbench.
In 856cb74's message, change gc_iq_demod.vhd core to gc_iq_demodulator core.
guilhermerc
changed the title
David-Daminelli
force-pushed
the
iq-tb
branch
2 times, most recently
from
935a543 to
e19810e
Compare
guilhermerc
requested changes
Jul 11, 2025
guilhermerc
left a comment
guilhermerc
left a comment
There was a problem hiding this comment.
In the commit message, change gc_iq_demodulator.vhd core to gc_iq_demodulator core.
David-Daminelli
force-pushed
the
iq-tb
branch
4 times, most recently
from
7a4e384 to
a1310e6
Compare
guilhermerc
requested changes
Jul 11, 2025
Added testbench for the gc_iq_modulator.vhd core. This loops through some I and Q values, generate the expected output sine and asserts the output.
guilhermerc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a testbench for the IQ modulator and demodulator