Open
Conversation
This code has been refactored from a CERN fork to provide STM32F30x support in OpenMMC. CERN Fork: https://gitlab.cern.ch/twlostow/openmmc/-/tree/tom-rf Original Authors: Tomasz Wlostowski <tomasz.wlostowski@cern.ch>, Adam Wujek <adam.wujek@cern.ch>
This code has been refactored from a CERN fork to provide STM32F30x support in OpenMMC CERN Fork: https://gitlab.cern.ch/twlostow/openmmc/-/tree/tom-rf Original Authors: Tomasz Wlostowski <tomasz.wlostowski@cern.ch>, Adam Wujek <adam.wujek@cern.ch>
This code has been refactored from a CERN fork to provide STM32F30x support in OpenMMC CERN Fork: https://gitlab.cern.ch/twlostow/openmmc/-/tree/tom-rf Original Author: Adam Wujek <adam.wujek@cern.ch>
This code has been refactored from a CERN fork to provide STM32F30x support in OpenMMC CERN Fork: https://gitlab.cern.ch/twlostow/openmmc/-/tree/tom-rf Original Authors: Tomasz Wlostowski <tomasz.wlostowski@cern.ch>, Adam Wujek <adam.wujek@cern.ch>
Member
|
Hi Michael, We are still reviewing your PR before merging, but so far we have the following observations:
As we discussed previously, we will merge this on the @gustavosr8 is our new intern that will start working on the openMMC project shortly, so now we will have someone dedicated to help on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the initial STM32 support provided by CERN, this PR captures the work Diamond has done to integrate this into the upstream.