Fix RTM disable payload power error check#226
Merged
Conversation
augustofg
force-pushed
the
fix-rtm-disable-pp-err-detect
branch
from
55a3f2f to
9d2ca4a
Compare
Commit 331bb6f replaced the rtm_quiesce() function with rtm_disable_payload_power(), but the later returns the mmc_err enum type, so it should be compared with the enum values. MMC_OK is the first value defined in the mmc_err enum type, so it was represented numerically as 0, and would evaluate as false in the if statement.
augustofg
force-pushed
the
fix-rtm-disable-pp-err-detect
branch
from
9d2ca4a to
4a1fe86
Compare
gustavosr8
reviewed
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 331bb6f replaced the rtm_quiesce() function with rtm_disable_payload_power(), but the last returns the mmc_err enum type, so it should be compared with the enum values.
MMC_OK is the first value defined in the mmc_err enum type, so it was represented numerically as 0, and would evaluate as false in the if statement.