Skip to content

Workaround payload loss of power due a voltage dip in the 12V power rail [AFCv4.0] #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
augustofg merged 3 commits into from
May 27, 2025
Merged

Workaround payload loss of power due a voltage dip in the 12V power rail [AFCv4.0] #232

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdcc14e
Print debug information before turning off payload power [afcv4.0]
augustofg Feb 4, 2025
ffac655
Print Payload Power ADC voltage measurement [afcv4.0]
augustofg Feb 17, 2025
29cb5cc
Check payload power voltage twice before updating pp_good [afcv4.0]
augustofg Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions port/board/afc-v4/payload.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include "eeprom_24xx02.h"
#include "i2c_mapping.h"
#include "pin_mapping.h"
#include <stdint.h>

/* payload states
* 0 - No power
Expand Down Expand Up @@ -150,7 +151,7 @@ static void check_fpga_reset( void )
last_state = cur_state;
}

uint8_t payload_check_pgood()
uint8_t payload_check_pgood(uint16_t* adc_readout)
{
/* Threshold set to ~8V */
const uint16_t PAYLOAD_THRESHOLD = 0x9B2;
Expand All @@ -162,6 +163,7 @@ uint8_t payload_check_pgood()
while (Chip_ADC_ReadStatus(LPC_ADC, ADC_CH1, ADC_DR_DONE_STAT) != SET) {}
/* Read ADC value */
Chip_ADC_ReadValue(LPC_ADC, ADC_CH1, &dataADC);
*adc_readout = dataADC;

if (dataADC > PAYLOAD_THRESHOLD){
return 1;
Expand Down Expand Up @@ -296,7 +298,8 @@ void vTaskPayload( void *pvParameters )
uint8_t new_state = -1;

/* Payload power good flag */
uint8_t PP_good = 0;
uint8_t pp_good = 0;
uint8_t last_pp_goods[2] = {0, 0};

/* Payload DCDCs good flag */
uint8_t DCDC_good = 0;
Expand All @@ -309,6 +312,8 @@ void vTaskPayload( void *pvParameters )
TickType_t xLastWakeTime;
mmc_err err;

uint16_t pp_adc_val;

xLastWakeTime = xTaskGetTickCount();

for ( ;; ) {
Expand Down Expand Up @@ -358,13 +363,19 @@ void vTaskPayload( void *pvParameters )
xEventGroupClearBits(amc_payload_evt, PAYLOAD_MESSAGE_REBOOT | PAYLOAD_MESSAGE_WARM_RST);
}

PP_good = payload_check_pgood();
last_pp_goods[1] = last_pp_goods[0];
last_pp_goods[0] = payload_check_pgood(&pp_adc_val);

if (last_pp_goods[0] == last_pp_goods[1]) {
pp_good = last_pp_goods[0];
}

DCDC_good = gpio_read_pin(PIN_PORT(GPIO_PGOOD_P1V0), PIN_NUMBER(GPIO_PGOOD_P1V0));

switch(state) {

case PAYLOAD_NO_POWER:
if (PP_good) {
if (pp_good) {
new_state = PAYLOAD_POWER_GOOD_WAIT;
}
break;
Expand All @@ -379,7 +390,7 @@ void vTaskPayload( void *pvParameters )
hotswap_clear_mask_bit( HOTSWAP_AMC, HOTSWAP_BACKEND_PWR_SHUTDOWN_MASK );
hotswap_clear_mask_bit( HOTSWAP_AMC, HOTSWAP_BACKEND_PWR_FAILURE_MASK );

if ( QUIESCED_req || ( PP_good == 0 ) ) {
if ( QUIESCED_req || ( pp_good == 0 ) ) {
new_state = PAYLOAD_SWITCHING_OFF;
} else if ( DCDC_good == 1 ) {
new_state = PAYLOAD_STATE_FPGA_SETUP;
Expand Down Expand Up @@ -410,7 +421,12 @@ void vTaskPayload( void *pvParameters )
break;

case PAYLOAD_FPGA_ON:
if ( QUIESCED_req == 1 || PP_good == 0 || DCDC_good == 0 ) {
if (last_pp_goods[0] == 0) {
printf("Payload power ADC value %u\n", pp_adc_val);
}

if ( QUIESCED_req == 1 || pp_good == 0 || DCDC_good == 0 ) {
printf("QUIESCED_req = %d, pp_good = %d, DCDC_good = %d\n", QUIESCED_req, pp_good, DCDC_good);
new_state = PAYLOAD_SWITCHING_OFF;
}
break;
Expand Down Expand Up @@ -441,7 +457,7 @@ void vTaskPayload( void *pvParameters )

case PAYLOAD_QUIESCED:
/* Wait until power goes down to restart the cycle */
if (PP_good == 0 && DCDC_good == 0) {
if (pp_good == 0 && DCDC_good == 0) {
new_state = PAYLOAD_NO_POWER;
}
break;
Expand Down