chore(PLAT-2937) - Add publish.yml workflow using Trusted Provider#42
chore(PLAT-2937) - Add publish.yml workflow using Trusted Provider#42burkematthew merged 1 commit intomainfrom
Conversation
Summary of ChangesHello @burkematthew, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's Node.js environment and refining its release process. It bumps the required Node.js version, formally declares engine requirements, and refactors release-related npm scripts for better modularity. While the PR title suggests adding a publishing workflow, the provided changes focus on these foundational updates to the development environment and build process. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js version and refactors the release scripts, likely to support a new CI/CD publishing workflow. The changes to enforce specific node and npm versions via the engines field are a good improvement for environment consistency. I've provided one suggestion to further improve the refactored npm scripts in package.json for a better developer experience when creating changelogs.
1e39e90 to
516e70f
Compare
516e70f to
56e059b
Compare
Problem
We need to move towards supporting the OIDC/Trusted Provider authentication method. Let's move towards a more standardized way of publishing packages to npm at Lob, leveraging a triggered Github action that automatically bumps the version for us.
Solution