Skip to content

chore(PLAT-2937) - Add publish.yml workflow using Trusted Provider#42

Merged
burkematthew merged 1 commit intomainfrom
plat-2937/chore/trusted-provider
Nov 11, 2025
Merged

chore(PLAT-2937) - Add publish.yml workflow using Trusted Provider#42
burkematthew merged 1 commit intomainfrom
plat-2937/chore/trusted-provider

Conversation

@burkematthew
Copy link
Contributor

@burkematthew burkematthew commented Nov 11, 2025

Problem

We need to move towards supporting the OIDC/Trusted Provider authentication method. Let's move towards a more standardized way of publishing packages to npm at Lob, leveraging a triggered Github action that automatically bumps the version for us.

Solution

  • Update the existing publish github action workflow file to use the Trusted Provider/OIDC method. Also, incorporate the changelog logic.
  • Require an engine of npm >=11.
  • Since we need npm >=11, move to node versions of 20, 22, and 24.

@gemini-code-assist
Copy link

Summary of Changes

Hello @burkematthew, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the project's Node.js environment and refining its release process. It bumps the required Node.js version, formally declares engine requirements, and refactors release-related npm scripts for better modularity. While the PR title suggests adding a publishing workflow, the provided changes focus on these foundational updates to the development environment and build process.

Highlights

  • Node.js Version Update: The required Node.js version has been updated from 20.15.0 to 20.17.0 across the project configuration.
  • Engine Requirements Enforced: The engines field has been added to both package.json and package-lock.json to explicitly enforce Node.js >=20.17.0 and npm >=11.5.1.
  • Release Script Refactoring: The release:major, release:minor, and release:patch npm scripts in package.json have been refactored into more granular changelog:* and version:commit commands, separating changelog generation from version bumping and committing.
  • Peer Dependency Marking: Several development dependencies, including @redis/client, acorn, eslint, joi, and knex, have been explicitly marked as peer: true within package-lock.json.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/publish.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js version and refactors the release scripts, likely to support a new CI/CD publishing workflow. The changes to enforce specific node and npm versions via the engines field are a good improvement for environment consistency. I've provided one suggestion to further improve the refactored npm scripts in package.json for a better developer experience when creating changelogs.

@burkematthew burkematthew force-pushed the plat-2937/chore/trusted-provider branch 2 times, most recently from 1e39e90 to 516e70f Compare November 11, 2025 22:16
@burkematthew burkematthew force-pushed the plat-2937/chore/trusted-provider branch from 516e70f to 56e059b Compare November 11, 2025 22:19
@burkematthew burkematthew merged commit aa97be5 into main Nov 11, 2025
3 checks passed
@burkematthew burkematthew deleted the plat-2937/chore/trusted-provider branch November 11, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants