-
Notifications
You must be signed in to change notification settings - Fork 8
#BGSTB-393(fix): updating axios package and fix issue with #281 #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
025095f
updating axios package
mananshah78424 377776e
test fixes
mananshah78424 a9bc94c
consolidate assertions, use parallely creation, make more parameterized
mananshah78424 813d41e
increase timeout
mananshah78424 2b31a38
replace expect.any(Object) with specific properties
mananshah78424 33b5186
add retry logic to bank account creations and use URLSearchParams
mananshah78424 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved dependency stability and to ensure reproducible builds, it's a good practice to pin the exact version of dependencies. Since the tests were run against
axios@1.11.0(as indicated bypackage-lock.json), pinning to this specific version would prevent potential issues from future1.xreleases ofaxiosthat might be pulled in automatically due to the caret^range.